Fix: ata asm sizes, add gitignore, and delete artifacts.#2
Open
Daniel-Aguila wants to merge 1 commit intoFreeze-Software:mainfrom
Open
Fix: ata asm sizes, add gitignore, and delete artifacts.#2Daniel-Aguila wants to merge 1 commit intoFreeze-Software:mainfrom
Daniel-Aguila wants to merge 1 commit intoFreeze-Software:mainfrom
Conversation
ATA_REG_DATA is 0x1F0 which is taken as 32bits, but asm inw/outw are asking for 16bit, so I added "w" to modify and enforce the 16bit size. As well as added "memory" clobber, to avoid unwanted memory reordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATA_REG_DATA is 0x1F0 which is taken as 32bits, but asm inw/outw are asking for 16bit, so I added "w" to modify and enforce the 16bit size. As well as added "memory" clobber, to avoid unwanted memory reordering.
Before this update, I was unable to properly 'make all'